Skip to content

[ONB-4421] [Compose] Add payment method installments - #56

Merged
fin-compose[bot] merged 1 commit into
mainfrom
compose/payment-method-installments-7866
Nov 17, 2026
Merged

fin-compose[bot] merged 1 commit into
mainfrom
compose/payment-method-installments-7866

Conversation

@FranciscaOtero

Copy link
Copy Markdown
Contributor

Contexto

The public API spec (openapi_spec/main-api.json in fintoc-rails, 8a2cfe7..abfc7e7) added a way to ask which installments a saved card accepts. The SDK had no method for it, and a new payment_intents error code had no error class.

¿Qué hay de nuevo?

  • client.v2.payment_methods.installments(id, amount:, currency:) → GET /v2/payment_methods/{id}/installments (fintoc-com/fintoc-rails#21303). Returns { available_installments: [...] }, like mandate_document.
  • Fintoc::Errors::ChargeProcessingFeeNotAllowedError for the charge_processing_fee_not_allowed code of POST /v2/payment_intents (fintoc-com/fintoc-rails#21411).
  • README example.

Already covered by the SDK, no code changes needed:

  • Crossborder beneficiaries, quotes and transfers, incl. cancel, simulate_credit and evm_address (fintoc-com/fintoc-rails#20605, #20906, #20911, #20943, #21253).
  • Account and account number certificate (fintoc-com/fintoc-rails#20588).
  • checkout_sessions.confirm (fintoc-com/fintoc-rails#20935).
  • New request params are forwarded as-is via **params: off_session and payment_method_options.card.installments in payment_intents.create (#21419), payment_method_options.card.bins and ui_mode: 'fields' in checkout_sessions.create (#20751, #20837, #21037), data.plaft.cmf_regulated / cmf_registration_number in onboardings (#20814).
  • payment_methods.list(payment_options: { off_session: true }) already sends payment_options[off_session] (#21274); added a test.
  • setup_intent.error_reason new values (#20993) and the webhook endpoints 422 (#20758) need no changes: error_reason is a plain string and the 422 error codes already map to existing classes or FintocError.

Tests

  • Unit tests (WebMock) for installments, its 422 error, the off_session list filter and the new error class resolution.

Release notes

  • Added payment_methods.installments(id, amount:, currency:) to get the installments a saved card accepts for an amount.
  • Added Fintoc::Errors::ChargeProcessingFeeNotAllowedError.

Safety Checks

  • Versión y CHANGELOG actualizados (si corresponde)

Consideraciones

  • Left out: description/example-only spec changes (#20836, #20874, #20978, #20998, #21391, #21411 besides the error code, and others). No synthetic cassettes added.

🤖🐙 Created with Compose · View session

…_allowed error

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
@FranciscaOtero FranciscaOtero added the agent:compose PR created by Compose AI agent label Nov 17, 2026
@FranciscaOtero FranciscaOtero self-assigned this Nov 17, 2026
@fin-hermes fin-hermes Bot added the size/S label Nov 17, 2026
@FranciscaOtero

Copy link
Copy Markdown
Contributor Author

fin review

@fin-hermes fin-hermes Bot added the risk:low label Nov 17, 2026

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FranciscaOtero
FranciscaOtero marked this pull request as ready for review November 17, 2026 12:05
@FranciscaOtero FranciscaOtero added the release:minor Publica una versión minor al mergear label Nov 17, 2026

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@fin-compose
fin-compose Bot merged commit 927b64b into main Nov 17, 2026
9 checks passed
@fin-compose
fin-compose Bot deleted the compose/payment-method-installments-7866 branch November 17, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:compose PR created by Compose AI agent release:minor Publica una versión minor al mergear risk:low size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant